Skip to content
/event-loopPublic

Ensure large timer interval does not overflow on 32bit systems#132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsor merged 1 commit into from
Dec 4, 2017
Merged

Ensure large timer interval does not overflow on 32bit systems #132

jsor merged 1 commit into from
Dec 4, 2017

Conversation

@clue
Copy link
Member

@clueclue commented Dec 4, 2017•
edited
Loading

Resolves / closes#19
Supersedes / closes#96
Supersedes / closes#23

@clueclue added the bug label Dec 4, 2017
@clueclue added this to the v0.5.0 milestone Dec 4, 2017
jsor
jsor approved these changes Dec 4, 2017
View reviewed changes
@jsorjsor merged commit 5da8da1 into reactphp:masterDec 4, 2017
@clueclue deleted the overflow-32bit branch December 4, 2017 15:10
@clueclue mentioned this pull request Dec 4, 2017
Merged
@clueclue mentioned this pull request Jun 25, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsorjsorjsor approved these changes

@WyriHaximusWyriHaximusWyriHaximus approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

StreamSelectLoop: Int overflow if the timer interval is big on 32-bit systems

3 participants

@clue@jsor@WyriHaximus