StreamSelectLoop timer interval limit fix (on 32-bit systems)

[alexmnv]

Fix timer interval limit issue in \React\EventLoop\StreamSelectLoop (issue #19)
On 32-bit systems it's not possible to set a timer interval higher than 2147 seconds.

[clue]

I have yet to do some more in-depth testing, but on first sight the changes LGTM 👍

Afaict 32-bit systems are becoming increasingly less common, yet this change affects all versions. Is this worth considering, i.e. is the overhead even noticeable?

A slightly less intrusive alternative might be to just cap the maximum $timeout value at an (arbitrary) value. Having the loop tick once every x minutes even when no events occur is unlikely to cause any performance issues.

[WyriHaximus]

2147 is just over 35 minutes. Tbh if you need a timer to run in 10 minutes or later you maybe should consider a more persistent storage of your timer event. For example dead letter exchanges in rabbitmq. Capping it to x minutes makes more sense to me.

[clue]

Unfortunately this PR is technically a BC break, as consumers could depend on the protected API.

I think it makes sense to fix the underlying issue, but we won't be able merge this into the v0.4 series like this.

[clue]

Ping @alexmnv, what do you think about the above comments?

Also, may I ask you to rebase this on the new "0.4" branch so we get this in for the upcoming v0.4.3 release?

[jsor]

When $timeout === null, both $tv_sec and $tv_usec will become true because of the elvis operator.

This should be

$tv_sec = $timeout === null ? null : floor($timeout); // convert the fractional part of $timeout to microseconds$tv_usec = $timeout === null ? null : round(fmod($timeout, 1) * self::MICROSECONDS_PER_SECOND);

[alexmnv]

@jsor You're right. I missed it.