Responses to HEAD requests and certain status codes never contain a body#156
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsor approved these changes Mar 31, 2017
WyriHaximus approved these changes Mar 31, 2017
Merged
This was referenced Nov 4, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures we obey the HTTP specs and never send a response body for
HEADrequest. Similarly, certain status codes do not permit a message body.This happens automatically, so that consumers of this lib do not have to take care of this. This also applies to our error handling logic, which now uses the same routines to ensure an invalid
HEADrequest does not send a response body.See https://tools.ietf.org/html/rfc7230#section-3.3, https://tools.ietf.org/html/rfc7230#section-3.3.1 and https://tools.ietf.org/html/rfc7230#section-3.3.2
Builds on top of #152