Skip to content

Improve assigning Content-Length for 304 Not Modified response#430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WyriHaximus merged 1 commit into from
Nov 7, 2021
Merged

Improve assigning Content-Length for 304 Not Modified response #430

WyriHaximus merged 1 commit into from
Nov 7, 2021

Conversation

@clue
Copy link
Member

@clueclue commented Nov 5, 2021•
edited
Loading

This changeset ensures we preserve any explicit Content-Length response headers and do not assign a Content-Length: 0 by default for a 304 Not Modified response.

Builds on top of #429, #188 and #156
Refs tornadoweb/tornado#1736 and ninenines/cowboy#1153

@clueclue added this to the v1.6.0 milestone Nov 5, 2021
@clueclue requested a review from WyriHaximusNovember 5, 2021 08:22
@clueclue mentioned this pull request Nov 5, 2021
Merged
@clue
Copy link
MemberAuthor

clue commented Nov 7, 2021

Rebased on master to resolve merge conflict now that #429 is in :shipit:

@WyriHaximusWyriHaximus merged commit e19e987 into reactphp:masterNov 7, 2021
@clueclue deleted the no-content-length branch November 7, 2021 09:49
@clueclue mentioned this pull request Feb 4, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WyriHaximusWyriHaximusWyriHaximus approved these changes

@SimonFringsSimonFringsSimonFrings approved these changes

Assignees

No one assigned

Labels

bugnew feature

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue@WyriHaximus@SimonFrings