Fix expected error code in tests when ext-sockets is not enabled

[lucasnetau]

The expected error code when ext-sockets is not enabled (SOCKET_EMSGSIZE is not defined) is 90 per the two places that OverFlowException is created in class Transaction

http/src/Io/Transaction.php

Lines 173 to 176 in 212382c

	returnreject(new \OverflowException(
	'Response body size of ' . $size . ' bytes exceeds maximum of ' . $this->maximumSize . ' bytes',
	\defined('SOCKET_EMSGSIZE') ? \SOCKET_EMSGSIZE : 90
	));

http/src/Io/Transaction.php

Lines 205 to 208 in 212382c

	$reject(new \OverflowException(
	'Response body size exceeds maximum of ' . $this->maximumSize . ' bytes',
	\defined('SOCKET_EMSGSIZE') ? \SOCKET_EMSGSIZE : 90
	));

[SimonFrings]

@lucasnetau Thanks for bringing this up 👍

Seems like a reasonable change to me, but I don't have at much insights on this as @clue and @WyriHaximus, so interested in their opinion on this.

[clue]

@lucasnetau Thank you for looking into this, changes LGTM!

This fixes a small oversight in our test suite only that I've introduced when removing the dependency on reactphp/promise-stream (#482).

Once merged, we should probably backport the same changes to the 1.x branch as well 👍

[WyriHaximus]

Once merged, we should probably backport the same changes to the 1.x branch as well 👍

Just filed #539 to address this in the 1.x branch.

[WyriHaximus]

Thanks for taking the time to file this fix, LGTM 👍