Fix expected error code in tests when ext-sockets is not enabled#539
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
clue approved these changes Aug 29, 2024
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
@WyriHaximus Thanks for the backport, changes LGTM. It's a small changeset, but should this use the same authorship information as #532?
MemberAuthor
WyriHaximus commented Aug 29, 2024
Sure, will somehow add that information later today 👍 |
This is a backport of reactphp#532 and corrects an oversight introduced in reactphp#482.
WyriHaximusforce-pushed the 1.x-fix-expected-error-code-in-tests-when-ext-sockets-is-not-enabled branch from 22dfc8f to e0ab174CompareMemberAuthor
WyriHaximus commented Aug 30, 2024
@clue Updated the commit, @lucasnetau is now the author |
clue approved these changes Aug 30, 2024
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
WyriHaximus deleted the 1.x-fix-expected-error-code-in-tests-when-ext-sockets-is-not-enabled branch Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #532 and corrects an oversight introduced in #482.