Run tests on PHP 8.4 and update test environment#543
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
clue approved these changes May 23, 2025
Member
clue left a comment
clue left a comment There was a problem hiding this comment.
@PaulRotmann Thanks for looking into this, changes LGTM! 
WyriHaximus approved these changes May 29, 2025
WyriHaximus merged commit 11b03a2 into reactphp:3.x 9 checks passed
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus added a commit to WyriHaximus-labs/http that referenced this pull request Oct 14, 2025
Builds on top of reactphp#508 by porting reactphp#543 to v1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #536 and clue/framework-x#267.
In order to avoid segfault with Xdebug 3.4.2 on PHP 8.1+ (https://bugs.xdebug.org/view.php?id=2332), i also updated the test suite to use PCOV instead of Xdebug on PHP 8+ as discussed in reactphp/socket#323.