Update test suite to use PCOV to avoid segfault with Xdebug 3.4.2#323
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
WyriHaximus merged commit 78ebd28 into reactphp:3.x 19 checks passed
Uh oh!
There was an error while loading. Please reload this page.
WyriHaximus added a commit to WyriHaximusNet/docker-php that referenced this pull request May 11, 2025
WyriHaximus added a commit to WyriHaximusNet/docker-php that referenced this pull request May 11, 2025
MemberAuthor
clue commented Jul 21, 2025
For the reference: Xdebug 3.4.5 has been released last week (https://github.com/xdebug/xdebug/releases/tag/3.4.5) with the above bug fixed, so the segfault should no longer be an issue. We've briefly discussed reverting this internally and figured this would introduce unneeded noise at the moment, so we'll likely stick with a mix of Xdebug and PCOV for any projects migrated in the meantime. There is a chance either may break in the future, so I think it's good we have both at our disposal in case this happens. |
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 14, 2025
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 23, 2025
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 23, 2025
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 25, 2025
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
WyriHaximus added a commit to WyriHaximus-labs/event-loop that referenced this pull request Oct 25, 2025
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the test suite to use PCOV instead of Xdebug on PHP 8+ to avoid a segfault with Xdebug 3.4.2 on PHP 8.1+ (https://bugs.xdebug.org/view.php?id=2332).
Unfortunately, it doesn't look like the upstream bug in Xdebug is an easy fix nor like it is going to be fixed any time soon, so for the time being I'd propose switching to PCOV to unblock our development. PCOV is pretty much a drop-in replacement on newer PHP versions (but noticeably faster), and test coverage should not be affected at all. Once merged, we should apply similar changes to our other components and other supported branches.
Builds on top of clue/framework-x#278 and #321
Supersedes / closes#322