Skip to content

Conversation

@clue
Copy link
Member

@clueclue commented Jul 8, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)$socket = newReact\Socket\Server('127.0.0.1:8080', $loop); $connector = newReact\Socket\Connector($loop); // new (using default loop)$socket = newReact\Socket\Server('127.0.0.1:8080'); $connector = newReact\Socket\Connector();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/stream#159 and reactphp/dns#182

@clueclue added this to the v1.8.0 milestone Jul 8, 2021
@clueclue changed the title Simplify usage by supporting new default loop[WIP] Simplify usage by supporting new default loopJul 8, 2021
@clueclueforce-pushed the default-loop branch 3 times, most recently from 3c57fd1 to d52ab10CompareJuly 8, 2021 14:08
@clue
Copy link
MemberAuthor

clue commented Jul 8, 2021

The first commit updates this to the currently unreleased EventLoop, Stream and DNS components to show how the new default loop can be used in this component (the build should be green). The second commit updates this to the releases that have yet to be tagged. This is expected to fail at the moment and should be green once the releases are tagged and the build is restarted.

This is ready for review. I will restart the build and merge once reviewed and the components are tagged.

@clueclue changed the title [WIP] Simplify usage by supporting new default loopSimplify usage by supporting new default loopJul 11, 2021
@clue
Copy link
MemberAuthor

clue commented Jul 11, 2021

Restarted build and everyhing's green now that reactphp/event-loop v1.2.0, reactphp/stream v1.2.0 and reactphp/dns v1.8.0 have been released :shipit:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@clue@WyriHaximus