[1.x] Improve PHP 8.4+ support by avoiding implicitly nullable types#318
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cedric-anne approved these changes Jul 25, 2024
This was referenced Nov 21, 2024
This was referenced Dec 27, 2024
Merged
WyriHaximus added a commit to WyriHaximus-labs/socket that referenced this pull request Oct 14, 2025
Builds on top of reactphp#310 and reactphp#318 by porting reactphp#321 to v1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset backports #317 from
3.xto1.xto improve PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.Builds on top of #317, #310 and #260, reactphp/promise#260, reactphp/dns#224, reactphp/stream#179, reactphp/async#87 and reactphp/promise-timer#70