- Notifications
You must be signed in to change notification settings - Fork 33
fix: log browser url to stderr instead of stdout#1136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
marceljk commented Nov 28, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
cgoetz-inovex left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, manual test successfull
0e74f2a to 6f9d56cCompare58a4b77 into mainUh oh!
There was an error while loading. Please reload this page.
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
* feat(cdn): add cdn client, config, list command * fix(cdn): generate docs * fix(cdn) fix linting issues * Update internal/cmd/beta/cdn/distribution/list/list.go Co-authored-by: Ruben Hönle <[email protected]> * Update internal/cmd/beta/cdn/distribution/list/list.go Co-authored-by: Ruben Hönle <[email protected]> * fix(cdn): rename sortBy params, use EnumSliceToStringSlice * fix(cdn): make `testNextPageID`, `testID` and `testStatus` constant * fix(cdn): add cdn subcommand to beta, generate docs * feat(cdn) add limit flag to distribution list * feat(cdn): add distribution create cmd * fix(cdn): generate distribution create docs * squash this * feat(cdn) implement cdn distribution create/delete/describe/update * squash * squash * fix(cdn) regenerate docs * fix(cdn) linting issues * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/secretsmanager (#1112) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serverbackup (#1111) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/ske (#1110) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serverupdate (#1109) * chore(deps): bump renovatebot/github-action from 44.0.3 to 44.0.4 (#1113) * feat(kms) describe key, keyring, wrappingkey (#1107) * feat(kms) describe key, keyring, wrappingkey * fix(kms): do not reuse buffer during output tests * fix(kms) use constant Time for TestOutputResult for constant table widths * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/rabbitmq (#1118) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/alb (#1117) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/mongodbflex (#1116) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serviceaccount (#1115) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/serviceenablement (#1123) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/dns (#1122) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/iaas (#1121) * fix(alb): print valid JSON/YAML output for list cmds (#1045) relates to STACKITCLI-273 / #893 * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/mariadb (#1129) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/redis (#1128) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/runcommand (#1127) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/authorization (#1120) * chore: increase linter timeout (#1131) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/intake (#1132) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/loadbalancer (#1133) * fix: log browser url to stderr instead of stdout (#1136) fixes#1125 * fix(deps): update module github.com/goccy/go-yaml to v1.19.0 (#1137) * feat(mongodbflex): add readAnyDatabase and stackitAdmin roles for users (#1049) Co-authored-by: Ruben Hoenle <[email protected]> * fix: refresh token flow uses x-www-form encoding (#1135) * chore(deps): update renovatebot/github-action action to v44.0.5 (#1141) * chore(deps): bump github.com/stackitcloud/stackit-sdk-go/services/sqlserverflex (#1139) * feat(cdn): add cdn client, config, list command * feat(cdn) implement cdn distribution create/delete/describe/update * fix(cdn) manual merge fixes * fix(cdn) review fixes - test Min - test JoinStringMap - rm superfluous var for constant - rm file committed by accident - add nil checks when dereferencing pointers * fix(cdn) replace utils.Min usage with builtin min * Update internal/cmd/beta/cdn/distribution/list/list.go Co-authored-by: Ruben Hönle <[email protected]> * fix(cdn) apply review comments - replace single char names with more descriptive ones - remove predefined mod functions - deduplicate ParseOriginRequestHeaders and test it - deduplicate ParseGeofencing and test it - add test FlagTo* funcs * fix(cdn) fix merge errors * fix(cdn) more merge errors, and single char renames * fix(cdn) JoinStringMap: define order * fix(cdn) define geofencing order * fix(cdn) review changes - fix `ID` spelling - add missing new line at end of output - rm TODO comment * feat(printer) make PromptForPassword scripting compatible * fix(cdn) add example to pass password in script * fix(docs) generate docs * fix(printer) make TestPromptForPassword compatible with older go versions * fix(printer) fix/ignore linting issues * fix(cdn) adjust list TestOutputResult expected to new printer changes * fix(cdn) rm superfluous model.AssumeYes checks * fix(fmt) run fmt --------- Co-authored-by: Ruben Hönle <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Marcel Jacek <[email protected]> Co-authored-by: stackit-pipeline <[email protected]> Co-authored-by: Piet van der Meulen <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Description
relates to #1125
Testing instructions
$ make build$ ./bin/stackit config set --session-time-limit 1s$ ./bin/stackit auth login$ ./bin/stackit network list -o json | jq-> should work
$ ./bin/stackit network list -o json | jq-> should fail
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)