Jorwoods/tasks no schedule#1297
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
jorwoods commented Oct 16, 2023
Seems that the token for the test coverage has some missing permissions. |
Contributor
bcantoni commented Oct 19, 2023
@jacalata could you take a look at the issue here with generating test coverage: https://github.com/tableau/server-client-python/actions/runs/6527723147/job/17869783004?pr=1297 |
jorwoodsforce-pushed the jorwoods/tasks_no_schedule branch from 02ac7fb to 11656c4Compare
jacalata approved these changes Jan 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My thoughts on resolving #1290 and adding type annotations on tasks. I noticed at the moment, running a task returns the raw
bytesfrom the server response. A change to the TSC API would be consuming that response and returning aJobItem.