Skip to content

Conversation

@gconklin
Copy link
Contributor

  1. logging to the root logger isn't correct
  2. the log line calls fetch_call() which makes a server request
  3. retuns the results of fetch_call() which is never used anywhere

Removing these lines from _set_default_permissions makes it more functionally equivalent to the above _set_permissions

1. logging to the root logger isn't correct 2. the log line calls fetch_call() which makes a server request 3. retuns the results of fetch_call() which is never used anywhere Removing these lines from _set_default_permissions makes it more functionally equivalent to the above _set_permissions
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @gconklin to sign the Salesforce Inc. Contributor License Agreement.

@bcantoni
Copy link
Contributor

@gconklin thanks for the PR! As a first time contributor I had to enable workflows to run here, so we should get the results shortly,

@jacalata
Copy link
Contributor

Hi @gconklin - last thing needed is a signed CLA. Did you run into any trouble doing that?

@gconklin
Copy link
ContributorAuthor

Hi @jacalata - when I go to sign it, it says I've already signed it.
"You already signed the CLA on 2023-10-19"
there's nothing else on the page except a logo of Salesforce cloud logo.

@jacalatajacalata merged commit d79ca4c into tableau:developmentJan 6, 2024
jacalata added a commit that referenced this pull request Jan 13, 2024
#1302#1300#1330#1328#1297#1307#1299 - fix filename handling in downloads - fix typing on revisions files - add typings - update urllib dependency
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gconklin@bcantoni@jacalata