Skip to content

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuisbnoordhuis commented Dec 22, 2016

@nodejs-github-botnodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Dec 22, 2016
@ofrobots
Copy link
Contributor

Thanks for fixing. IMO, this should be contributed upstream. The mirrors code is slated to go away soonish, but the code does exists upstream for now. /cc @hashseed.

@TimothyGu
Copy link
Member

Ping. Any updates?

@bnoordhuis
Copy link
MemberAuthor

I never got around to it because V8's debugger tests were in a severe state of flux. I'll see if I can get around to it this week, I have more patches that I need to upstream.

@fhinkelfhinkel added the stalled Issues and PRs that are stalled. label May 26, 2017
@targos
Copy link
Member

@bnoordhuis Knowing that the Debug API is going away, I suppose upstreaming this doesn't make much sense anymore.

@bnoordhuis
Copy link
MemberAuthor

Ah, I rather forgot about this PR. Are you suggesting I close it or that I merge it without upstreaming? I suppose it's still relevant in v6.x.

@TimothyGuTimothyGu mentioned this pull request Jul 10, 2017
@targos
Copy link
Member

I'm suggesting to merge in v6.x without upstreaming.

@MylesBorinsMylesBorins changed the base branch from master to v6.x-stagingJuly 10, 2017 09:52
@MylesBorinsMylesBorins changed the base branch from v6.x-staging to masterJuly 10, 2017 09:53
@bnoordhuis
Copy link
MemberAuthor

Opened #14343 for v6.x, input welcome.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stalledIssues and PRs that are stalled.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@bnoordhuis@ofrobots@TimothyGu@targos@fhinkel@nodejs-github-bot