[v6.x] v8: handle proxy objects in MakeMirror()#14343
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added v6.x v8 engine 
refack approved these changes Jul 18, 2017
cjihrig approved these changes Jul 18, 2017
Contributor
MylesBorins commented Jul 18, 2017
There seem to be quite a few failures in CI... I'm running a job against the staging branch to see if they are related to this PR |
Contributor
MylesBorins commented Jul 18, 2017
Re running V8 Ci https://ci.nodejs.org/job/node-test-commit-v8-linux/794/ |
Member
targos commented Jul 18, 2017
@MylesBorins you need #14219 to unbreak V8 CI |
Contributor
MylesBorins commented Jul 18, 2017
One more time with V8 fix https://ci.nodejs.org/job/node-test-commit-v8-linux/795/ |
Contributor
MylesBorins commented Jul 18, 2017
So it looks like it is breaking during compilation... assuming that it is rebasing, then this change appears to be breaking stuff. @bnoordhuis would you be up for rebasing against v6.x-staging just to play it safe |
MemberAuthor
bnoordhuis commented Jul 19, 2017
Rebased, although I get the impression it's a CI bug more than anything else. I saw this in the s390x build log: Node CI: https://ci.nodejs.org/job/node-test-pull-request/9249/ |
Member
jasnell commented Jul 19, 2017
fwiw, I've seen that pop up in CI from time to time. I agree it's likely not an issue with this PR |
jasnell approved these changes Jul 19, 2017
addaleax changed the title Contributor
MylesBorins commented Jul 21, 2017
@bnoordhuis do we land both fixes or only need to land one or the other? /cc @nodejs/v8 for review |
For consistency with 4.x and 8.x. This commit also contains a forward port of nodejs#14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: nodejs#14234 Refs: nodejs#14205 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
This is an initial step to eliminate most of parsing errors. Backport-PR-URL: nodejs#14067 PR-URL: nodejs#12563 Refs: nodejs#12557 (comment) Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Backport-PR-URL: nodejs#14067 PR-URL: nodejs#12563 Refs: nodejs#12557 (comment) Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
* Install [email protected] * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: nodejs#12563 Refs: nodejs#12640 Refs: nodejs#14047 PR-URL: nodejs#14067 Reviewed-By: James Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>
The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
In preparation for applying the more strict indentation linting available in ESLint 4.0.0, correct minor indentation issues in tools/eslint-rules/required-modules.js. This is the only file with indentation that does not conform to the stricter checks. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
ESLint 4.0.0 provides stricter (and more granular) indentation checking than previous versions. Apply the stricter indentation rules to the tools directory. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Fix previously-unnoticed typo in `required-modules.js`. Backport-PR-URL: nodejs#14360 Refs: nodejs#13758 (comment) PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: nodejs#14370 PR-URL: nodejs#13770 Reviewed-By: Colin Ihrig <[email protected]>
This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. Backport-PR-URL: nodejs#14373 PR-URL: nodejs#13074 Reviewed-By: Anna Henningsen <[email protected]>
This fixes a race condition in the watchdog timer used for vm timeouts. The condition would terminate the main stack's execution instead of the code running under the sandbox. Backport-PR-URL: nodejs#14373 PR-URL: nodejs#13074 Reviewed-By: Anna Henningsen <[email protected]>
Backport-PR-URL: nodejs#14416 PR-URL: nodejs#13206 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
This commit allows self signed certificates to work with unix sockets by forwarding the rejectUnauthorized option. Backport-PR-URL: nodejs#14415Fixes: nodejs#13470 PR-URL: nodejs#13505 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
root_cert_store is defined as extern in node_crypto.h but only used in node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all be accessing the same X509_STORE through the root_cert_store pointer as far as I can tell. Am I missing something here? This commit suggests removing it from the header and making it static in node_crypto.cc. PR-URL: nodejs#13194 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
MemberAuthor
bnoordhuis commented Jul 24, 2017
Okay, let's land both. Rebased again. |
MylesBorinsforce-pushed the v6.x-staging branch 2 times, most recently from 0ae4c46 to d75363bCompareContributor
MylesBorins commented Aug 14, 2017
landed in d75363b...f3dfbeb |
Contributor
Had to back it out... the changes were breaking test-child-process-detached on AIX + vs2015 edit: I don't think this is related, am going to reland |
MylesBorinsforce-pushed the v6.x-staging branch 2 times, most recently from cebce8b to 5a93c16CompareMylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Aug 16, 2017
PR-URL: #14343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
MylesBorins commented Aug 16, 2017
problem was unrelated relanded in d35e5c7...5a93c16 |
Merged
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Sep 5, 2017
PR-URL: #14343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Sep 5, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #8224 and #10406, and the continuation of #10409.
First commit is a back-port of #10409 to v6.x, the second one is what I think is a better fix: it turns the proxy into a black box that cannot be inspected (because inspection has side-effects with proxied objects.)
Input welcome.
Node CI: https://ci.nodejs.org/job/node-test-pull-request/9215/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/792/