gh-100039: enhance __signature__ to work with str and callables#100168
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Callables should be either class- or static-methods. Enum now uses the classmethod version to greatly improve the help given for enums and flags.
ethanfurman added type-feature 
✅ Deploy Preview for python-cpython-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ethanfurman requested review from JelleZijlstra, iritkatriel, larryhastings and mdboomCallables should be either class- or static-methods. Enum now uses the classmethod version to greatly improve the help given for enums and flags.
MemberAuthor
ethanfurman commented Dec 11, 2022
Note that |
| @classmethod | ||
| def__signature__(cls): | ||
| ifcls._member_names_: | ||
| return'(*values)' |
There was a problem hiding this comment.
Why *values? If I understand correctly this corresponds to calls like Color(1), which only accept exactly one argument.
MemberAuthor
There was a problem hiding this comment.
In 3.12 multiple values are accepted to match multiple values being used to create the member:
class Point(Enum): ORIGIN = 0, 0 >>> Point(0, 0) <Point.ORIGIN: (0, 0))> carljm added a commit to carljm/cpython that referenced this pull request Dec 16, 2022
* main: pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541) pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168) pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302) "Compound statement" docs: Fix with-statement step indexing (python#100286) pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278)
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Dec 18, 2022
* origin/main: (1306 commits) Correct CVE-2020-10735 documentation (python#100306) pythongh-100272: Fix JSON serialization of OrderedDict (pythonGH-100273) pythongh-93649: Split tracemalloc tests from _testcapimodule.c (python#99551) Docs: Use `PY_VERSION_HEX` for version comparison (python#100179) pythongh-97909: Fix markup for `PyMethodDef` members (python#100089) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythongh-99240: Reset pointer to NULL when the pointed memory is freed in argument parsing (python#99890) pythonGH-98831: Add DECREF_INPUTS(), expanding to DECREF() each stack input (python#100205) pythongh-78707: deprecate passing >1 argument to `PurePath.[is_]relative_to()` (pythonGH-94469) pythongh-99540: Constant hash for _PyNone_Type to aid reproducibility (pythonGH-99541) pythongh-100039: enhance __signature__ to work with str and callables (pythonGH-100168) pythongh-99830: asyncio: Document returns of remove_{reader,writer} (python#100302) "Compound statement" docs: Fix with-statement step indexing (python#100286) pythonGH-90043: Handle NaNs in COMPARE_OP_FLOAT_JUMP (pythonGH-100278) Improve stats presentation for calls. (pythonGH-100274) Better stats for `LOAD_ATTR` and `STORE_ATTR` (pythonGH-100295) pythongh-81057: Move the Cached Parser Dummy Name to _PyRuntimeState (python#100277) Document that zipfile's pwd parameter is a `bytes` object (python#100209) pythongh-99767: mark `PyTypeObject.tp_watched` as internal use only in table (python#100271) Fix typo in introduction.rst (python#100266) ...
skirpichev added a commit to skirpichev/cpython that referenced this pull request Feb 27, 2024
This is an alternative to python#100168.
This was referenced Feb 27, 2024
skirpichev added a commit to skirpichev/cpython that referenced this pull request Mar 1, 2024
This is an alternative to python#100168.
skirpichev added a commit to skirpichev/cpython that referenced this pull request Mar 2, 2024
This is an alternative to python#100168.
ethanfurman pushed a commit that referenced this pull request Oct 8, 2024
efimov-mikhail pushed a commit to efimov-mikhail/cpython that referenced this pull request Oct 9, 2024
…ute (pythonGH-116234) This is an alternative to pythonGH-100168.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callables should be either class- or static-methods. Enum now uses the classmethod version to greatly improve the help given for enums and flags.
__text_signature__ofEnumType.__call__and derivatives #100039