Better stats for LOAD_ATTR and STORE_ATTR#100295
Merged
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides better stats for
LOAD_ATTRandSTORE_ATTR, differentiating several class attributes.There is a slight change to specializing behavior, but it seems to make no difference in practice.
The main change is for simple attributes of a class.
Consider
c.iis not specialized and the failure is reported as "not in dict".iisn't in the instance's dict, but that's not the problem.With this PR, the failure is reported as "class attr simple" which is much more informative.
The change in specialization behavior is that if an instance attribute shadows a non-data descriptor, it is no longer specialized.
This has no effect on the hit rate, which remains at 82%, but does convert some misses to deferreds.