v10.16.1 proposal#28731

BethGriggs · 2019-07-17T11:10:26Z

2019-07-31, Version 10.16.1 'Dubnium' (LTS), @BethGriggs

Notable changes

deps: upgrade openssl sources to 1.1.1c (Sam Roberts) #28212
stream: do not unconditionally call \_read() on resume() (Anna Henningsen) #26965
worker: fix nullptr deref after MessagePort deser failure (Anna Henningsen) #25076

Commits

[65ef26fdcb] - async_hooks: avoid double-destroy HTTPParser (Gerhard Stoebich) #27477
[8f5d6cf5f5] - deps: update archs files for OpenSSL-1.1.1c (Sam Roberts) #28212
[9e62852724] - deps: upgrade openssl sources to 1.1.1c (Sam Roberts) #28212
[c59e0c256d] - deps: updated openssl upgrade instructions (Sam Roberts) #28212
[609d2b9ea4] - deps: V8: backport f27ac28 (Michaël Zasso) #28061
[8f780e8f99] - deps: cherry-pick 88f8fe1 from upstream V8 (Yang Guo) #24514
[ad588eb5fc] - doc: adjust TOC margins (Roman Reiss) #28075
[b3d8a1b1d0] - doc: add missing changes entry (Ruben Bridgewater) #24758
[819a647d8f] - esm: fix esm load bug (ZYSzys) #25491
[f34bb968c4] - process: make stdout and stderr emit 'close' on destroy (Matteo Collina) #26691
[f9e8e8856a] - src: fix Get() usage in tls_wrap.cc (cjihrig) #24060
[b689008dea] - src: in-source comments and minor TLS cleanups (Sam Roberts) #25713
[76af23a32b] - src: remove internalBinding('config').warningFile (Joyee Cheung) #24959
[b7dbc1c537] - src: fix warning in cares_wrap.cc (cjihrig) #25230
[a8f78f02cb] - src: fulfill Maybe contract in InlineDecoder (Anna Henningsen) #25140
[0dee607409] - src: extract common Bind method (Jon Moss) #22315
[08a32fbf57] - src: elevate v8 namespaces for node_process.cc (Jayasankar) #24578
[f3841c6750] - stream: convert existing buffer when calling .setEncoding (Anna Henningsen) #27936
[274b97c4ea] - stream: do not unconditionally call \_read() on resume() (Anna Henningsen) #26965
[044e753aaf] - stream: make _read() be called indefinitely if the user wants so (Matteo Collina) #26135
[f332265cda] - test: remove util.inherits() usage (ZYSzys) #25245
[ada0ed55d1] - test: fix pty test hangs on aix (Ben Noordhuis) #28600
[2ae99160e5] - test: skip stringbytes-external-exceed-max on AIX (Sam Roberts) #28516
[39637cb95f] - test: skip tests related to CI failures on AIX (Sam Roberts) #28469
[35be08a16f] - test: clean up build files (Gabriel Schulhof) #28297
[cc3ca08046] - test: clearing require cache crashes esm loader (Antoine du HAMEL) #25491
[75052cadaa] - tls: add debugging to native TLS code (Anna Henningsen) #26843
[99dad28ebf] - tls: add CHECK for impossible condition (Anna Henningsen) #26843
[5ffe04753e] - tls: renegotiate should take care of its own state (Sam Roberts) #25997
[4a607fab49] - tools: replace rollup with ncc (Rich Trott) #24813
[14090b59fc] - worker: fix nullptr deref after MessagePort deser failure (Anna Henningsen) #25076

Fixes: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Original commit message: Fix collection iterator preview with deleted entries We used to assume that we know the remaining entries returned by the iterator based on the current index. However, that is not accurate, since entries skipped by the current index could be deleted. In the new approach, we allocate conservatively and shrink the result. [email protected] Bug: v8:8433 Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325966 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{#57360} [The backport to v10.x resolves merge conflicts due to a different way of accessing the “hole” value in V8, different signatures of the `Handle` constructor and the `Shrink()` method, and neighbouring-line conflicts in the test file.] Refs: v8/v8@88f8fe1Fixes: #27882 Backport-PR-URL: #27894 PR-URL: #24514 Refs: #24053 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Original commit message: [turbofan] Pin pure unreachable values to effect chain (in rep selection) Currently, if we lower to a pure computation that is unreachable because of some runtime check, we just rename it with DeadValue. This is problematic if the pure computation gets later eliminated - that allows the DeadValue node float above the check that makes it dead. As we conservatively lower DeadValues to debug-break (i.e., crash), we might induce crash where we should not. With this CL, whenever we lower an impossible effectful node (i.e., with Type::None) to a pure node in simplified lowering, we insert an Unreachable node there (pinned to the effect chain) and mark the impossible node dead (and make it depend on the Unreachable node). Bug: chromium:910838 Change-Id: I218991c79b9e283a9dd5beb4d3f0c4664be76cb2 Reviewed-on: https://chromium-review.googlesource.com/c/1365274 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Jaroslav Sevcik <[email protected]> Cr-Commit-Position: refs/heads/master@{#58066} Refs: v8/v8@f27ac28 PR-URL: #28061Fixes: #27107 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Michael Dawson <[email protected]>

In the initial version of this test there were two zero-length writes to force tls state to cycle. The second is not necessary, at least not now, but the first was. The renegotiate() API should ensure that packet exchange takes place, not its users, so move the zero-length write into tls. See: #14239 See: b1909d3a70f9 Backport-PR-URL: #27938 PR-URL: #25997 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Elevate namespace for repeated entities. Resolved conflicts. PR-URL: #24578 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>

Avoid that destroy hook is invoked twice - once via `Parser::Free()` and once again via `Parser::Reinitialize()` by clearing the async_id in `EmitDestroy()`. Partial backport of #27477, a full backport would require also #25094 which has a dont-land-on-v10.x label on it. Fixes: #26961 Backport-PR-URL: #27986 PR-URL: #27477 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>

`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of functionality, so a common `Bind` was extracted to remove duplication. Backport-PR-URL: #28222 PR-URL: #22315 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>

This would previously always have crashed when deserializing a `MessagePort` fails, because there was always at least one `nullptr` entry in the vector. PR-URL: #25076 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>

Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: #25140 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: James M Snell <[email protected]>

This commit fixes the following warning: ./src/cares_wrap.cc:1268:5: warning: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int' [-Wsign-compare] CHECK_EQ(ret->Length(), a_count + aaaa_count); PR-URL: #25230 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: James M Snell <[email protected]>

The `util.format()` behavior changed recently. Add the changes entry to document the new BigInt behavior. PR-URL: #24758 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Instead use `require('internal/options')` lazily. Also refactor the call site a bit so that the option is queried only once since it's synchronous anyway. PR-URL: #24959 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Fixes: #26097 PR-URL: #26135 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

`readable.resume()` calls `.read(0)`, which in turn previously set `needReadable = true`, and so a subsequent `.read()` call would call `_read()` even though enough data was already available. This can lead to elevated memory usage, because calling `_read()` when enough data is in the readable buffer means that backpressure is not being honoured. Fixes: #26957 PR-URL: #26965 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Fix: #26550 PR-URL: #26691 Fixes: https://github.com/falseFixes: #26550 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Convert already-stored chunks when `.setEncoding()` is called so that subsequent `data` events will receive decoded strings, as they expect. Fixes: #27932 PR-URL: #27936 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Rich Trott <[email protected]>

PR-URL: #28075 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>

Renamed some internal C++ methods and properties for consistency, and commented SSL I/O. - Rename waiting_new_session_ after is_waiting_new_session(), instead of using reverse naming (new_session_wait_), and change "waiting" to "awaiting". - Make TLSWrap::ClearIn() return void, the value is never used. - Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the arguments, remove them from the js wrapper. - Remove call of setTicketKeys(getTicketKeys()), its a no-op. Backport-PR-URL: #27967 PR-URL: #25713 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>

Backport-PR-URL: #27967 PR-URL: #24060 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Backport-PR-URL: #27967 PR-URL: #26843 Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Files generated by the build process were accidentally included as part of an earlier commit. This removes them. PR-URL: #28297 Reviewed-By: Beth Griggs <[email protected]>

mhdawson

LGTM

mhdawson · 2019-07-17T13:33:47Z

@gabrielschulhof were there some N-API backports you thought would be in the next 10.x release?

Some pty tests persistently hung on the AIX CI buildbots. Fix that by adding a helper script that properly sets up the pty before spawning the script under test. On investigation I discovered that the test runner hung when it tried to close the slave pty's file descriptor, probably due to a bug in AIX's pty implementation. I could reproduce it with a short C program. The test runner also leaked file descriptors to the child process. I couldn't convince python's `subprocess.Popen()` to do what I wanted it to do so I opted to move the logic to a helper script that can do fork/setsid/etc. without having to worry about stomping on state in tools/test.py. In the process I also uncovered some bugs in the pty module of the python distro that ships with macOS 10.14, leading me to reimplement a sizable chunk of the functionality of that module. And last but not least, of course there are differences between ptys on different platforms and the helper script has to paper over that. Of course. Really, this commit took me longer to put together than I care to admit. Caveat emptor: this commit takes the hacky ^D feeding to the slave out of tools/test.py and puts it in the *.in input files. You can also feed other control characters to tests, like ^C or ^Z, simply by inserting them into the corresponding input file. I think that's nice. Fixes: nodejs/build#1820Fixes: #28489 PR-URL: #28600 Backport-PR-URL: #28826 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: #28212 Reviewed-By: Beth Griggs <[email protected]>

This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1c.tar.gz $ mv openssl-1.1.1c openssl $ git add --all openssl $ git commit openssl PR-URL: #28212 Reviewed-By: Beth Griggs <[email protected]>

After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h $ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: #28212 Reviewed-By: Beth Griggs <[email protected]>

Replace rollup + plugins + config file with zeit/ncc package designed to do the particular task that we're leveraging rollup for but with zero-ish configuration. (rollup can do a whole lot more, but we're using a tiny portion of its functionality.) PR-URL: #24813 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Backport-PR-URL: #28736

Backport-PR-URL: #28795 PR-URL: #25245 Refs: #24755 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Notable changes: - **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212) - **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965) - **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076) PR-URL: #28731

BethGriggs · 2019-07-26T10:29:44Z

test-release-candidate: https://ci.nodejs.org/job/node-release-candidate/10/

This can fail when terminating a Worker that loads the `uv` binding at the same time. Refs: #25061 (comment)Fixes: #25134 PR-URL: #25079 Backport-PR-URL: #28832 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Notable changes: - **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212) - **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965) - **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076) PR-URL: #28731

nodejs-github-bot · 2019-07-31T11:55:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24799/ ✅

Notable changes: - **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212) - **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965) - **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076) PR-URL: #28731

PR-URL: #28731

Notable changes: - **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212) - **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965) - **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076) PR-URL: #28731

Refs: nodejs/node#28731

ZYSzysand others added 23 commits June 6, 2019 13:59

esm: fix esm load bug
819a647
Fixes: #25482 Backport-PR-URL: #27874 PR-URL: #25491 Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>

stream: make _read() be called indefinitely if the user wants so
044e753
Fixes: #26097 PR-URL: #26135 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

process: make stdout and stderr emit 'close' on destroy
f34bb96
Fix: #26550 PR-URL: #26691 Fixes: https://github.com/falseFixes: #26550 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

doc: adjust TOC margins
ad588eb
PR-URL: #28075 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]>

src: fix Get() usage in tls_wrap.cc
f9e8e88
Backport-PR-URL: #27967 PR-URL: #24060 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

test: clean up build files
35be08a
Files generated by the build process were accidentally included as part of an earlier commit. This removes them. PR-URL: #28297 Reviewed-By: Beth Griggs <[email protected]>

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2019

BethGriggs changed the base branch from master to v10.xJuly 17, 2019 12:30

mhdawson approved these changes Jul 17, 2019
View reviewed changes

bnoordhuisand others added 6 commits July 25, 2019 13:55

deps: updated openssl upgrade instructions
c59e0c2
Patching the s390 asm rules is no longer required. See: openssl/openssl#8351 PR-URL: #28212 Reviewed-By: Beth Griggs <[email protected]>

test: remove util.inherits() usage
f332265
Backport-PR-URL: #28795 PR-URL: #25245 Refs: #24755 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Hakerh400 mentioned this pull request Jul 26, 2019
httpresponse pause()/resume() leads to out-of-memory error when using local server nodejs/help#2074
Closed

BethGriggs force-pushed the v10.16.1-proposal branch from 4d0e87c to 2d18f84Compare July 26, 2019 10:28

ZYSzys approved these changes Jul 26, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

BethGriggs force-pushed the v10.16.1-proposal branch from 2d18f84 to fe32fe8Compare July 30, 2019 20:31

This comment has been minimized.
Sign in to view

BethGriggs force-pushed the v10.16.1-proposal branch from fe32fe8 to a395299Compare July 31, 2019 15:55

BethGriggs merged commit a395299 into v10.xJul 31, 2019

BethGriggs added a commit that referenced this pull request Jul 31, 2019
Working on v10.16.2
f025f85
PR-URL: #28731

BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Jul 31, 2019
Blog: v10.16.1 release post
0a42b4a
Refs: nodejs/node#28731

BethGriggs mentioned this pull request Jul 31, 2019
Blog: v10.16.1 release post nodejs/nodejs.org#2358
Merged

BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Jul 31, 2019
Blog: v10.16.1 release post (#2358)
8934916
Refs: nodejs/node#28731

BethGriggs deleted the v10.16.1-proposal branch August 6, 2019 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

v10.16.1 proposal#28731

v10.16.1 proposal #28731

Uh oh!

BethGriggs commented Jul 17, 2019•
edited
Loading

Uh oh!

mhdawson left a comment

Uh oh!

mhdawson commented Jul 17, 2019

Uh oh!

BethGriggs commented Jul 26, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Jul 31, 2019•
edited by BethGriggs
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

v10.16.1 proposal#28731

v10.16.1 proposal #28731

Uh oh!

Conversation

BethGriggs commented Jul 17, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2019-07-31, Version 10.16.1 'Dubnium' (LTS), @BethGriggs

Notable changes

Commits

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Jul 17, 2019

Uh oh!

BethGriggs commented Jul 26, 2019

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Jul 31, 2019• edited by BethGriggs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

BethGriggs commented Jul 17, 2019•
edited
Loading

nodejs-github-bot commented Jul 31, 2019•
edited by BethGriggs
Loading