gh-134584: Eliminate redundant refcounting from _CALL_BUILTION_O#136056
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
35 tasks
Member
Fidget-Spinner commented Jun 28, 2025
Thanks for the PR! Let's wait till Mark merges the TOS caching work before we continue (see the main issue's comment), thanks! |
ContributorAuthor
AndPuQing commented Jun 28, 2025
Got it, I'll hold off on this until the TOS caching PR is in. Thanks for letting me know! |
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Éric <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
…-141881) Most of the `self.assertTrue(self.called)` checks are flaky because the worker threads may sometimes finish before the main thread calls `self.during_threads()`.
Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
…honGH-141908) * test_hashlib: better handle support for SHA3 It's possible that the SSL library supports only SHA3 algo and doesn't have SHAKE one. The current test wrongly detect this and set both HASH and HASHXOF to None expecting to have the extra SHA3 attributes present but this should only be true for SHAKE algo. To better handle this, move the HASH condition to a dedicated try-expect condition and check if HASHXOF is None in the relevant code effectively checking if SHA3 is supported by the SSL library but SHAKE algo needs to use the sha3module one. Signed-off-by: Christian Marangi <[email protected]> * rework the conditional import for all its attrs --------- Signed-off-by: Christian Marangi <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
…le files (python#141934) gh-1381228: Split Modules/_remote_debugging_module.c into multiple files
…() accept UserString as argument (pythonGH-140945)
…ons in stable ABI (pythonGH-139166) * Make Py_{SIZE,IS_TYPE,SET_SIZE} regular functions in stable ABI Group them together with Py_TYPE & Py_SET_TYPE to cut down on repetitive preprocessor macros. Format repetitive definitions in object.c more concisely. Py_SET_TYPE is still left out of the Limited API.
Co-authored-by: Petr Viktorin <[email protected]>
…s to stable ABI manifest (python#141910) These were added to the limited API in 3.5. Not including them in `Misc/stable_abi.toml` was a bug.
AndPuQing requested review from a team, 1st1, Eclips4, ZeroIntensity, abalkin, ammaraskar, asvetlov, brandtbucher, brettcannon, carljm, diegorusso, encukou, ericsnowcurrently, ericvsmith, freakboy3742, hugovk, iritkatriel, isidentical, methane, mhsmith, ncoghlan, pganssle, picnixz, savannahostrowski, serhiy-storchaka, sethmlarson and willingc as code owners
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.